Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runtime: TestPhysicalMemoryUtilization failures #35580

Closed
ianlancetaylor opened this issue Nov 14, 2019 · 5 comments
Closed

runtime: TestPhysicalMemoryUtilization failures #35580

ianlancetaylor opened this issue Nov 14, 2019 · 5 comments
Labels
FrozenDueToAge NeedsInvestigation release-blocker
Milestone

Comments

@ianlancetaylor ianlancetaylor added NeedsInvestigation release-blocker labels Nov 14, 2019
@ianlancetaylor ianlancetaylor added this to the Go1.14 milestone Nov 14, 2019
@mknyszek
Copy link
Contributor

@mknyszek mknyszek commented Nov 14, 2019

I suspect the problem here is that the scavenger's scavAddr may already be too low (for some reason, and only by a little bit) to adequately achieve the desired physical memory utilization. I have some ideas on how to fix it and will come back to this bug shortly.

@mknyszek mknyszek self-assigned this Nov 14, 2019
@gopherbot
Copy link

@gopherbot gopherbot commented Nov 19, 2019

Change https://golang.org/cl/207999 mentions this issue: runtime: make the scavenger loop around the address space

@gopherbot
Copy link

@gopherbot gopherbot commented Nov 19, 2019

Change https://golang.org/cl/207998 mentions this issue: runtime: wake scavenger and update address on sweep done

@gopherbot
Copy link

@gopherbot gopherbot commented Nov 21, 2019

Change https://golang.org/cl/208377 mentions this issue: runtime: increase TestPhysicalMemoryUtilization threshold

@mknyszek
Copy link
Contributor

@mknyszek mknyszek commented Nov 21, 2019

Found the problem. It's that the page cache was hiding memory from the scavenger (which is intentional). Just uploaded a fix to the test to account for that.

@golang golang locked and limited conversation to collaborators Nov 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
FrozenDueToAge NeedsInvestigation release-blocker
Projects
None yet
Development

No branches or pull requests

3 participants