Skip to content

/go

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/gopls: optimize find references #35597

Closed
stamblerre opened this issue Nov 14, 2019 · 2 comments
Assignees
@matloob
Labels
NeedsFix Tools gopls
Milestone
Unreleased

Comments

@stamblerre
Copy link
Contributor

@stamblerre stamblerre commented Nov 14, 2019 •
edited

A few optimizations that we should add:

  • Only search for references in reverse dependencies
    • This will mean making sure that we have a consistent set of reverse dependencies
    • Right now, the snapshot's importedBy map can be invalidated/incomplete when metadata is changed
  • Don't search other packages for unexported identifiers
    • Except for test variants
@gopherbot gopherbot added this to the Unreleased milestone Nov 14, 2019
@gopherbot gopherbot added the Tools label Nov 14, 2019
@gopherbot

This comment has been minimized.

Sign in to view
Copy link

@gopherbot gopherbot commented Nov 18, 2019

Change https://golang.org/cl/207601 mentions this issue: internal/lsp: don't search other packages for unexported references
gopherbot pushed a commit to golang/tools that referenced this issue Nov 18, 2019
@stamblerre
internal/lsp: don't search other packages for unexported references
faf0e61 
Updates golang/go#35597

Change-Id: Ib17e94a99d49fe78f09f711b86f9115ac4aadeb9
Reviewed-on: https://go-review.googlesource.com/c/tools/+/207601
Run-TryBot: Rebecca Stambler <rstambler@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Michael Matloob <matloob@golang.org>
@gopherbot

This comment has been minimized.

Sign in to view
Copy link

@gopherbot gopherbot commented Nov 24, 2019

Change https://golang.org/cl/208657 mentions this issue: internal/lsp: only search for references in reverse dependencies
gopherbot pushed a commit to golang/tools that referenced this issue Nov 25, 2019
@stamblerre
internal/lsp: only search for references in reverse dependencies
a911d90 
Updates golang/go#35597

Change-Id: I78e83ad0ee1ae3c59a7452c467b3abd34587a845
Reviewed-on: https://go-review.googlesource.com/c/tools/+/208657
Run-TryBot: Rebecca Stambler <rstambler@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Ian Cottrell <iancottrell@google.com>
@stamblerre stamblerre closed this Dec 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@matloob matloob

Labels
NeedsFix Tools gopls
Projects
None yet
Milestone
  Unreleased
3 participants
@stamblerre @gopherbot @matloob
You can’t perform that action at this time.