Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/gopls: find implementations sometimes returns interface itself #35601

Closed
muirdm opened this issue Nov 14, 2019 · 2 comments
Closed

x/tools/gopls: find implementations sometimes returns interface itself #35601

muirdm opened this issue Nov 14, 2019 · 2 comments
Assignees
Labels
Milestone

Comments

@muirdm
Copy link

@muirdm muirdm commented Nov 14, 2019

For example, when I run find-implementations on the "matcher" interface in tools/internal/lsp/source/completion.go, I get back a result referring to the "matcher" interface itself.

Edit: found an example in a module based repo so I got rid of GOPATH related stuff.

@gopherbot gopherbot added this to the Unreleased milestone Nov 14, 2019
@gopherbot

This comment has been minimized.

Copy link

@gopherbot gopherbot commented Nov 14, 2019

Thank you for filing a gopls issue! Please take a look at the Troubleshooting guide, and make sure that you have provided all of the relevant information here.

@muirdm muirdm changed the title x/tools/gopls: find implementations returns interface itself in GOPATH mode x/tools/gopls: find implementations sometimes returns interface itself Nov 15, 2019
@ridersofrohan

This comment has been minimized.

Copy link

@ridersofrohan ridersofrohan commented Nov 25, 2019

Fixed in #73db347

@ridersofrohan ridersofrohan self-assigned this Nov 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.