Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/gopls: implementations sometimes returns no results #35602

Closed
muirdm opened this issue Nov 15, 2019 · 2 comments
Closed

x/tools/gopls: implementations sometimes returns no results #35602

muirdm opened this issue Nov 15, 2019 · 2 comments
Assignees
Labels
Milestone

Comments

@muirdm
Copy link

@muirdm muirdm commented Nov 15, 2019

When finding implementations of an interface method I sometimes unexpectedly get back no results. In the below setup, when finding implementations on the "U()" interface method, I get back zero results when I expect one in blah.go

-- go.mod --
module foo

-- foo.go --
package foo

import "foo/blah"

type Foo struct {
	blah.Foo
}

type U interface {
  U() // <-- find implementations here
}

-- blah/blah.go --
package blah

type Foo struct {
}

func (Foo) U()  {
}
@gopherbot gopherbot added this to the Unreleased milestone Nov 15, 2019
@gopherbot gopherbot added the Tools label Nov 15, 2019
@gopherbot

This comment has been minimized.

Copy link

@gopherbot gopherbot commented Nov 15, 2019

Thank you for filing a gopls issue! Please take a look at the Troubleshooting guide, and make sure that you have provided all of the relevant information here.

@gopherbot gopherbot added the gopls label Nov 15, 2019
@ridersofrohan

This comment has been minimized.

Copy link

@ridersofrohan ridersofrohan commented Nov 26, 2019

Fixed in #e13f15d

@ridersofrohan ridersofrohan self-assigned this Nov 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.