Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/go: do not treat branches with semantic-version names as releases #35671

Open
bcmills opened this issue Nov 18, 2019 · 2 comments
Open

cmd/go: do not treat branches with semantic-version names as releases #35671

bcmills opened this issue Nov 18, 2019 · 2 comments

Comments

@bcmills
Copy link
Member

@bcmills bcmills commented Nov 18, 2019

#33558 (comment) reports a situation in which a v2.0.0 branch was created and subsequently removed, but proxy.golang.org cached a v2.0.0+incompatible release.

If someone creates a branch named v2.0.0, they probably intend for that branch to contain the development leading up to v2.0.0, not for that branch as first published to be the definitive final release of v2.0.0. The go command should not mistake the former for the latter.

CC @jayconrod @mattn @thepudds

@bcmills bcmills added this to the Go1.15 milestone Nov 18, 2019
@bcmills
Copy link
Member Author

@bcmills bcmills commented Nov 18, 2019

See #29731, which also involves confusion between branches and versions.

@hajimehoshi
Copy link
Member

@hajimehoshi hajimehoshi commented Jun 18, 2020

Any updates on this? I think this is a very scary issue, since if a collaborator created a vN branch deliberately or not once, the repository's versioning would be corrupted forever...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.