Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upx/tools/gopls: support $/cancelRequest correctly #35679
Closed
Comments
This comment has been minimized.
This comment has been minimized.
|
Change https://golang.org/cl/207718 mentions this issue: |
gopherbot
pushed a commit
to golang/tools
that referenced
this issue
Nov 18, 2019
Quick fix to (*server).CancelRequest, but we haven't implemented actual support for it. Filed golang/go#35679 to track this. Change-Id: Ic0de01d49b779c4f0656587584fbd2bf8791d0ce Reviewed-on: https://go-review.googlesource.com/c/tools/+/207718 Run-TryBot: Rebecca Stambler <rstambler@golang.org> Reviewed-by: Peter Weinberger <pjw@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org>
This comment has been minimized.
This comment has been minimized.
|
$/cancelRequest is specially handled at the transport layer in order to be able to cancel requests out of the queue (and is fully implemented), the typescript generator used to know not to generate this function. |
This comment has been minimized.
This comment has been minimized.
|
Change https://golang.org/cl/207898 mentions this issue: |
gopherbot
pushed a commit
to golang/tools
that referenced
this issue
Nov 19, 2019
Paul Jolly observes that returning interface{} is not helpful.
Now CodeAction() returns []CodeAction.
The type in typescript is (Command | CodeAction)[] | null
but the choice is up to gopls, which returns []CodeAction.
Fixes golang/go#35688, golang/go#35679
Change-Id: I91c22bb0752431954ae2f993cb7b44726cf60e5c
Reviewed-on: https://go-review.googlesource.com/c/tools/+/207898
Reviewed-by: Rebecca Stambler <rstambler@golang.org>
This comment has been minimized.
This comment has been minimized.
|
That's what I thought - thanks for confirming. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
CL 207598 added a
(*server).CancelRequestfunction that we had not previously had. We should support cancellation of a specific request.