Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

time: TestTicker flaky with a short Duration on darwin-arm64-corellium builder #35692

Open
bcmills opened this issue Nov 19, 2019 · 4 comments
Open

Comments

@bcmills
Copy link
Member

@bcmills bcmills commented Nov 19, 2019

time.TestTicker is consistently failing on the darwin-arm64-corellium builder (https://build.golang.org/log/ae40104c94a528ac4e0295ddf4d3fb34620250df):

--- FAIL: TestTicker (2.39s)
    tick_test.go:63: saw 5 errors
    tick_test.go:25: 10 20ms ticks took 535.802667ms, expected [160ms,240ms]
    tick_test.go:25: 10 20ms ticks took 388.628375ms, expected [160ms,240ms]
    tick_test.go:25: 10 20ms ticks took 461.014083ms, expected [160ms,240ms]
    tick_test.go:25: 10 20ms ticks took 459.991375ms, expected [160ms,240ms]
    tick_test.go:25: 10 20ms ticks took 539.964292ms, expected [160ms,240ms]
FAIL
FAIL	time	6.615s

It's not obvious to me whether that's due to a bug in TestTicker, a bug in the timer support on that platform, or just a really overloaded builder.

CC @ianlancetaylor @bradfitz

@ianlancetaylor
Copy link
Contributor

@ianlancetaylor ianlancetaylor commented Nov 19, 2019

CC @eliasnaur in case there is something known about this.

@ianlancetaylor ianlancetaylor added this to the Go1.14 milestone Nov 19, 2019
@bcmills
Copy link
Member Author

@bcmills bcmills commented Nov 19, 2019

(And @steeve.)

@gopherbot
Copy link

@gopherbot gopherbot commented Nov 19, 2019

Change https://golang.org/cl/207839 mentions this issue: time: give TestTicker more time on darwin-arm64

gopherbot pushed a commit that referenced this issue Nov 19, 2019
The darwin-arm64-correlium builder was failing the test consistently
at the old values. Give the ticks more time to let the test pass.

Updates #35692

Change-Id: Ibc636cd4db2595c82f4e8c6c822c3df4c2b7e0a1
Reviewed-on: https://go-review.googlesource.com/c/go/+/207839
Run-TryBot: Ian Lance Taylor <iant@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
@ianlancetaylor
Copy link
Contributor

@ianlancetaylor ianlancetaylor commented Nov 19, 2019

I committed a workaround to make the test pass by increasing the timeouts.

It would be nice if someone could figure out why that is necessary, though.

@ianlancetaylor ianlancetaylor modified the milestones: Go1.14, Backlog Nov 19, 2019
@ianlancetaylor ianlancetaylor added help wanted and removed Builders labels Nov 19, 2019
@bcmills bcmills changed the title time: TestTicker consistently failing on darwin-arm64-corellium builder time: TestTicker flaky with a short Duration on darwin-arm64-corellium builder Nov 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.