Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runtime: timeout with GDB tests on aix/ppc64 #35710

Open
Helflym opened this issue Nov 20, 2019 · 5 comments
Milestone

Comments

@Helflym
Copy link
Contributor

@Helflym Helflym commented Nov 20, 2019

https://build.golang.org/log/98c7edecebf8de8d333d58a2286729cd6d821cef
https://build.golang.org/log/66fbb96c7aee8d5b6f191319ed3d8748f238255f
https://build.golang.org/log/8fba4a8ce0f6fb1cd3170013f51ff2fdbc35d269

Our GDB on AIX is a bit unstable and it doesn't seem to like the new page allocator for an unknown reason. Even an helloworld can't be run properly. It might be related to #35451 but I think it's more a GDB problem. The team working on it has been contacted. So until now, I would like to disable these tests in order to release our builder.

@gopherbot

This comment has been minimized.

Copy link

@gopherbot gopherbot commented Nov 20, 2019

Change https://golang.org/cl/207919 mentions this issue: runtime: disable GDB tests on AIX with -short

gopherbot pushed a commit that referenced this issue Nov 20, 2019
Since the new page allocator, AIX's GDB has trouble running Go programs.
It does work but it can be really slow. Therefore, they are disable when
tests are run with -short.

Updates: #35710

Change-Id: Ibfc4bd2cd9714268f1fe172aaf32a73612e262d6
Reviewed-on: https://go-review.googlesource.com/c/go/+/207919
Run-TryBot: Ian Lance Taylor <iant@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
@aclements

This comment has been minimized.

Copy link
Member

@aclements aclements commented Nov 20, 2019

/cc @mknyszek

@aclements aclements added this to the Backlog milestone Nov 20, 2019
@mknyszek

This comment has been minimized.

Copy link
Contributor

@mknyszek mknyszek commented Nov 22, 2019

@Helflym can you be more specific about how it doesn't like the new page allocator? Do you know if https://go-review.googlesource.com/c/go/+/207497/5 helps? (It should reduce the size of the PROT_NONE mappings from 9ish GiB to about 600 MiB).

@mknyszek

This comment has been minimized.

Copy link
Contributor

@mknyszek mknyszek commented Nov 22, 2019

I'm sorry, what I really meant to ask was, do you know for sure that it's the new page allocator it doesn't like? There were a number of other big changes that went into this release (e.g. asynchronous preemption). Maybe it really dislikes getting a lot of signals? I could see that being some very slow path in a gdb port.

@Helflym

This comment has been minimized.

Copy link
Contributor Author

@Helflym Helflym commented Nov 25, 2019

@mknyszek no, I'm sorry I thought it was related to the new page allocator. But indeed, as you said, it seems to be linked with 374c284 according to a git bisect. Moreover, our GDB already have trouble handling signals, so it seems legit.
I'm waiting for updates from the GDB team anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.