Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/build/cmd/gopherbot: make decision on whether anyone can add/remove release-blocker without specifying reason #35755

Open
dmitshur opened this issue Nov 21, 2019 · 8 comments

Comments

@dmitshur
Copy link
Contributor

@dmitshur dmitshur commented Nov 21, 2019

gopherbot removed the release-blocker label in #35482 (comment).

Need to investigate and understand why it happened.

@cespare
Copy link
Contributor

@cespare cespare commented Nov 21, 2019

I believe that @zx2c4 asked gopherbot to remove the label. Then maybe he deleted his own comment?

screen_20191121112737

@ALTree
Copy link
Member

@ALTree ALTree commented Nov 21, 2019

Shouldn't the gopherbot only process "please add label" comments from the issue creator?

It seems weird that a user that 1) is not the OP of the issue 2) has no "add/remove label" permission on the repository, can ask gopherbot to remove labels.

@dmitshur
Copy link
Contributor Author

@dmitshur dmitshur commented Nov 21, 2019

Thanks @cespare, that's very helpful.

The intention is for gopherbot to allow anyone to add or remove labels, as described at https://golang.org/wiki/gopherbot. There are some labels that are not allowed to be added/removed (see here).

We may want to rethink this interaction for release-blocker labels. /cc @golang/osp-team

@dmitshur dmitshur changed the title x/build/cmd/gopherbot: understand why it removed release-blocker label x/build/cmd/gopherbot: make decision on whether anyone can add/remove release-blocker without specifying reason Nov 21, 2019
@networkimprov
Copy link

@networkimprov networkimprov commented Nov 21, 2019

I'm the OP of that issue, and set the original release-blocker via gopherbot.

Since there's now the Backlog milestone, maybe anything milestoned for a release is effectively a release-blocker? Still, it's nice to see the big red flag in issue lists.

Tangentially, it's difficult/impossible to add the "help wanted" label via gopherbot, due to the space character. Maybe that could be renamed.

@zx2c4
Copy link
Contributor

@zx2c4 zx2c4 commented Nov 21, 2019

gopherbot removed the release-blocker label in #35482 (comment).

Need to investigate and understand why it happened.

I asked gopherbot to do this.

@dmitshur
Copy link
Contributor Author

@dmitshur dmitshur commented Nov 21, 2019

Thanks @zx2c4. I made #35757 about finding a way to improve it so that it's more clear when that happens. I left a comment on the original issue to give you more context on why we re-added the label.

Tangentially, it's difficult/impossible to add the "help wanted" label via gopherbot, due to the space character. Maybe that could be renamed.

@networkimprov Have you seen https://golang.org/wiki/gopherbot#addingremoving-labels? It describes how to work with labels containing spaces, using "help wanted" as an example. Please open a new issue about it if there is a problem.

@networkimprov
Copy link

@networkimprov networkimprov commented Nov 21, 2019

Testing... (I remember trying these before, without success, hm)

EDIT: Well the add variants of these commands worked, but not remove!

@gopherbot remove help wanted
@gopherbot remove OS-Windows, OS-Linux

EDIT: try add via edit
@gopherbot add OS-Linux

@dmitshur
Copy link
Contributor Author

@dmitshur dmitshur commented Nov 21, 2019

I don't think editing an existing comment is supported. Let me try a new comment.

@gopherbot remove help wanted
@gopherbot remove OS-Windows, OS-Linux

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
6 participants