Skip to content

/ go

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net/http: Server.ConnContext accidentally modifies context for all connections [1.13 backport] #35765

Closed
gopherbot opened this issue Nov 21, 2019 · 2 comments
Closed

net/http: Server.ConnContext accidentally modifies context for all connections [1.13 backport] #35765

gopherbot opened this issue Nov 21, 2019 · 2 comments
Labels
CherryPickApproved FrozenDueToAge
Milestone
Go1.13.5

Comments

@gopherbot
Copy link

@gopherbot gopherbot commented Nov 21, 2019

@bradfitz requested issue #35750 to be considered for backport to the next 1.13 minor release.

@gopherbot, please backport to Go 1.13.
@gopherbot gopherbot mentioned this issue Nov 21, 2019
Closed
@gopherbot gopherbot added this to the Go1.13.5 milestone Nov 21, 2019
@gopherbot
Copy link
Author

@gopherbot gopherbot commented Nov 21, 2019

Change https://golang.org/cl/208235 mentions this issue: [release-branch.go1.13] net/http: fix Server.ConnContext modifying context for all new connections
@gopherbot
Copy link
Author

@gopherbot gopherbot commented Nov 22, 2019

Closed by merging 94b6eec to release-branch.go1.13.
@gopherbot gopherbot closed this Nov 22, 2019
gopherbot pushed a commit that referenced this issue Nov 22, 2019
@rkollar @bradfitz
[release-branch.go1.13] net/http: fix Server.ConnContext modifying co…
94b6eec 
…ntext for all new connections

Updates #35750
Fixes #35765

Change-Id: I65d38cfc5ddd66131777e104c269cc3559b2471d
GitHub-Last-Rev: 953fdfd
GitHub-Pull-Request: #35751
Reviewed-on: https://go-review.googlesource.com/c/go/+/208318
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
(cherry picked from commit bbbc658)
Reviewed-on: https://go-review.googlesource.com/c/go/+/208235
Reviewed-by: Bryan C. Mills <bcmills@google.com>
@golang golang locked and limited conversation to collaborators Nov 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
CherryPickApproved FrozenDueToAge
Projects
None yet
Milestone
Go1.13.5
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
@bradfitz @gopherbot
You can’t perform that action at this time.