Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runtime: apparent deadlocks on Windows builders #35775

Open
bcmills opened this issue Nov 22, 2019 · 5 comments

Comments

@bcmills
Copy link
Member

@bcmills bcmills commented Nov 22, 2019

@bcmills

This comment has been minimized.

Copy link
Member Author

@bcmills bcmills commented Nov 22, 2019

I suspect that the same root cause is responsible for apparent deadlocks in the os/exec test.
2019-11-22T04:26:34-95be9b7/windows-amd64-2008
2019-11-21T22:20:17-94e9a5e/windows-amd64-2012

@ianlancetaylor

This comment has been minimized.

Copy link
Contributor

@ianlancetaylor ianlancetaylor commented Dec 2, 2019

2019-11-22T14:32:02-ea18a1c/windows-amd64-race
2019-11-22T15:32:23-c02f3b8/windows-amd64-longtest
2019-11-22T15:32:23-c02f3b8/windows-amd64-race
2019-11-22T19:01:42-c931f1b/windows-amd64-longtest
2019-11-22T19:01:42-c931f1b/windows-amd64-race
2019-11-22T19:03:26-28314cf/windows-amd64-race
2019-11-22T19:03:50-941ac9c/windows-amd64-race
2019-11-22T19:17:28-8324aca/windows-amd64-race
2019-11-22T21:09:43-9f3c2b6/windows-amd64-race
2019-11-22T22:24:38-980f0c0/windows-amd64-race
2019-11-22T23:23:13-6ba1bf3/windows-amd64-race
2019-11-23T00:06:41-f29e53d/windows-amd64-race
2019-11-23T11:00:41-6f7b96f/windows-amd64-longtest
2019-11-23T11:00:41-6f7b96f/windows-amd64-race
2019-11-24T15:06:38-b81dd1c/windows-amd64-longtest
2019-11-24T15:06:38-b81dd1c/windows-amd64-race
2019-11-25T15:08:18-01f15b6/windows-amd64-race
2019-11-25T16:26:15-476395c/windows-amd64-race
2019-11-25T16:43:27-e16f64c/windows-amd64-2016
2019-11-25T16:43:27-e16f64c/windows-amd64-race
2019-11-25T19:02:50-7adafc9/windows-amd64-2016
2019-11-25T21:15:11-5de3b97/windows-amd64-race
2019-11-25T23:37:03-87805c9/windows-amd64-race
2019-11-26T16:55:36-67f0f83/windows-amd64-race
2019-11-26T20:21:04-4a378d7/windows-amd64-2008
2019-11-27T01:29:00-c3f1492/windows-amd64-race
2019-11-27T01:30:19-b2482e4/windows-amd64-2008
2019-11-27T01:30:32-0f25102/windows-amd64-2008
2019-11-27T15:06:55-4e3d580/windows-amd64-race
2019-11-27T18:42:33-f1c8e2c/windows-amd64-race
2019-12-02T16:11:24-3edd1d8/windows-amd64-race
2019-12-02T16:45:37-bf3ee57/windows-amd64-race
2019-12-02T19:05:01-e4c01f0/windows-amd64-race
2019-12-02T20:12:54-a18608a/windows-amd64-2012
2019-12-02T20:12:54-a18608a/windows-amd64-longtest

@ianlancetaylor

This comment has been minimized.

Copy link
Contributor

@ianlancetaylor ianlancetaylor commented Dec 2, 2019

These failures are all either on the race builder or for tests with the race detector enabled. Seems like something makes deadlocks possible with the race detector.

The findflakes programs reports that this might be due to https://golang.org/issue/204340 "runtime: support preemption on windows/{386,amd64}".

CC @aclements @cherrymui

@bcmills

This comment has been minimized.

Copy link
Member Author

@bcmills bcmills commented Dec 4, 2019

Seems like something makes deadlocks possible with the race detector.

That could be related to #18717 — does the runtime assume that its preemption signals are eventually delivered?

@aclements

This comment has been minimized.

Copy link
Member

@aclements aclements commented Dec 5, 2019

does the runtime assume that its preemption signals are eventually delivered?

It does not. It will always try both a cooperative and a non-cooperative preemption and take whichever one it can get. If the signal goes missing, it will wait for a cooperative preemption just like before.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.