Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upruntime: apparent deadlocks on Windows builders #35775
Comments
This comment has been minimized.
This comment has been minimized.
I suspect that the same root cause is responsible for apparent deadlocks in the |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
These failures are all either on the race builder or for tests with the race detector enabled. Seems like something makes deadlocks possible with the race detector. The findflakes programs reports that this might be due to https://golang.org/issue/204340 "runtime: support preemption on windows/{386,amd64}". |
This comment has been minimized.
This comment has been minimized.
That could be related to #18717 — does the runtime assume that its preemption signals are eventually delivered? |
This comment has been minimized.
This comment has been minimized.
It does not. It will always try both a cooperative and a non-cooperative preemption and take whichever one it can get. If the signal goes missing, it will wait for a cooperative preemption just like before. |
Starting in November, there appears to be a dramatic uptick in the number of test timeouts on the
windows-*
builders.Many of these are for tests that normally run nearly instantaneously, such as
archive/tar
andbufio
.2019-11-22T03:06:22-0e02cfb/windows-amd64-race
2019-11-21T22:20:17-94e9a5e/windows-amd64-race
2019-11-21T19:27:16-f4a8bf1/windows-amd64-longtest
2019-11-21T19:09:24-2434869/windows-amd64-longtest
2019-11-21T19:09:24-2434869/windows-amd64-race
2019-11-21T16:56:47-37715cc/windows-amd64-longtest
2019-11-21T16:56:47-37715cc/windows-amd64-race
2019-11-21T16:01:14-c7e73ef/windows-amd64-race
2019-11-20T20:51:13-9852b4b/windows-amd64-race
2019-11-13T19:15:27-7ad2748/windows-amd64-longtest
2019-11-12T22:09:05-a56d755/windows-amd64-2016
2019-11-12T01:07:15-ec73263/windows-amd64-2012
2019-11-08T17:01:05-a5a6f61/windows-amd64-2012
2019-11-07T19:18:12-1b0b980/windows-amd64-2012
2019-11-07T05:52:34-3eabdd2/windows-amd64-longtest
2019-11-06T09:09:59-0c5d545/windows-amd64-2008
2019-11-06T02:52:51-f71bd51/windows-amd64-2016
2019-11-05T16:31:48-414c1d4/windows-amd64-2016
2019-11-05T14:44:56-e457cc3/windows-amd64-race
2019-11-05T05:19:08-d51f7f3/windows-amd64-longtest
2019-11-05T03:50:54-979d65d/windows-amd64-2016
2019-11-05T00:19:10-6cbd737/windows-amd64-race
2019-11-01T14:48:28-a570fcf/windows-amd64-2012
2019-03-19T08:30:50-451a2eb/windows-amd64-2008
2018-12-05T21:54:54-6454a09/windows-amd64-race
CC @ianlancetaylor @aclements @alexbrainman @zx2c4