x/tools/gopls: VSCode user snippets not sorting properly

[muirdm]

Imported from microsoft/vscode#84587

In https://go-review.googlesource.com/c/tools/+/202717 I added a workaround so our completion candidate order was maintained in VSCode. I made all gopls candidates appear to be "perfect" so VSCode had no additional sorting/filtering to do. This, however, made gopls candidates always match better than other VSCode completion items, such as user snippets.

[gopherbot]

Thank you for filing a gopls issue! Please take a look at the Troubleshooting guide, and make sure that you have provided all of the relevant information here.

[gopherbot]

Change https://golang.org/cl/208439 mentions this issue: internal/lsp: improve completion ordering workaround

[muirdm]

@tj The above change should resolve the issue. Are you able to test it out? Rough steps are:

1. Clone https://github.com/golang/tools
2. Grab https://go-review.googlesource.com/c/tools/+/208439/ ("Download patch" from upper right "..." menu)
3. cd gopls; go install
4. Confirm above built gopls binary is first in your PATH
5. Developer: Reload Window in VSCode

[tj]

Awesome! That fixed it, thanks a lot, I didn't realize the language server is in charge of so much, I'll keep that in mind next time.