x/tools/gopls: change to go.mod file does not trigger recalculation of diagnostics #35820
Milestone
Comments
This is a consequence of #31999. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
What version of Go are you using (
go version
)?Does this issue reproduce with the latest release?
Yes
What operating system and processor architecture are you using (
go env
)?go env
OutputWhat did you do?
This is probably related to #35548 but raising as a separate issue because it's specifically about changing
go.mod
as opposed to configuration.We have a
govim
test that verifies the setting of the"env"
valueGOFLAG=-mod=readonly
. It is based on the following setup:(
example.com/blah
is a valid module and is accessible FWIW, see later).We initially verify that the
go.mod
file is not changed bygopls
. This is fine. We also verify thatmain.go
has the following diagnostic:Also fine.
Then we update
go.mod
from outside the editor using:This change gets notified to
gopls
viadidChange
but the diagnostics formain.go
are not updated.What did you expect to see?
The diagnostics for
main.go
to be updated such that there are no errors.What did you see instead?
The diagnostics for
main.go
unchanged.See the interactions via the
gopls
log file: fail.logcc @stamblerre @matloob
The text was updated successfully, but these errors were encountered: