crypto/x509: error for "trailing data after X.509 subject" should say "issuer" instead

[egonk]

See the following error in parseCertificate:

go/src/crypto/x509/x509.go

Line 1377 in 87805c9

return nil, errors.New("x509: trailing data after X.509 subject")

It should probably say issuer, not subject.

Edit:

	var issuer, subject pkix.RDNSequence
	if rest, err := asn1.Unmarshal(in.TBSCertificate.Subject.FullBytes, &subject); err != nil {
		return nil, err
	} else if len(rest) != 0 {
		return nil, errors.New("x509: trailing data after X.509 subject")
	}
	if rest, err := asn1.Unmarshal(in.TBSCertificate.Issuer.FullBytes, &issuer); err != nil {
		return nil, err
	} else if len(rest) != 0 {
		return nil, errors.New("x509: trailing data after X.509 subject")
	}

[toothrot]

This looks pretty clearly incorrect. I'll take a look at this.

[gopherbot]

Change https://golang.org/cl/208978 mentions this issue: crypto/x509: correct error message for trailing issuer data