Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/gopls: errors when navigating through `git` ir `gitlens` URIs do not disappear anymore #35846

Closed
inliquid opened this issue Nov 26, 2019 · 2 comments
Labels
Milestone

Comments

@inliquid
Copy link

@inliquid inliquid commented Nov 26, 2019

  1. VS Code
  2. gopls@master

Previously these errors would disappear after git or gitlens tab was closed. Now they stay until language server restart.

изображение

@gopherbot gopherbot added this to the Unreleased milestone Nov 26, 2019
@gopherbot

This comment has been minimized.

Copy link

@gopherbot gopherbot commented Nov 26, 2019

Thank you for filing a gopls issue! Please take a look at the Troubleshooting guide, and make sure that you have provided all of the relevant information here.

@stamblerre

This comment has been minimized.

Copy link
Contributor

@stamblerre stamblerre commented Nov 30, 2019

This is a result of CL 208237, which removed the previous behavior of clearing diagnostics when a file was closed. This change was made because gopls now shows diagnostics for an entire workspace. I think the right approach here will be for us to handle these files correctly (without showing errors). As a result, I will close this issue in favor of #33699.

@stamblerre stamblerre closed this Nov 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.