Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/go/internal/modload: refactor error handling #35862

Open
jayconrod opened this issue Nov 26, 2019 · 3 comments
Open

cmd/go/internal/modload: refactor error handling #35862

jayconrod opened this issue Nov 26, 2019 · 3 comments

Comments

@jayconrod
Copy link
Contributor

@jayconrod jayconrod commented Nov 26, 2019

A number of exported functions in modload call base.Errorf and base.Fatalf. Instead of printing to stderr and exiting, functions in this package should return errors (ideally structured errors). This will make commands with non-standard error handling like go list -e, go build -n, and go mod download -json easier to implement.

@jayconrod jayconrod added this to the Go1.15 milestone Nov 26, 2019
@GrigoriyMikhalkin

This comment has been minimized.

Copy link
Contributor

@GrigoriyMikhalkin GrigoriyMikhalkin commented Dec 20, 2019

Hi, I would like to take this issue, would that be ok?

@jayconrod

This comment has been minimized.

Copy link
Contributor Author

@jayconrod jayconrod commented Dec 20, 2019

@GrigoriyMikhalkin If you haven't contributed to cmd/go before, this is probably not a good issue to start with. It will be a significant refactoring across several core packages, and it involves a lot of design decisions about how errors should be structured and handled.

Maybe try searching for issues with the help wanted label? Most of those are small and self-contained. Many are good first issues.

Note that we're pretty deep into the 1.14 code freeze right now, so any CLs except documentation and small bug fixes will be held until the 1.15 development cycle, which should start some time in February.

@GrigoriyMikhalkin

This comment has been minimized.

Copy link
Contributor

@GrigoriyMikhalkin GrigoriyMikhalkin commented Dec 20, 2019

Ok, thanks, i will look into other issues with help wanted labels)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.