Skip to content

/go

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/gopls: add extra testdata in gopls module #35880

Open
stamblerre opened this issue Nov 27, 2019 · 0 comments
Labels
NeedsFix Tools gopls help wanted
Milestone
gopls unplanned

Comments

@stamblerre
Copy link
Contributor

@stamblerre stamblerre commented Nov 27, 2019

CL 209220 doesn't work because the diff algorithm in golang.org/x/tools/internal/lsp doesn't support sub-line diffs. We should probably have a way to add extra testdata in the golang.org/x/tools/gopls so that we can add extra tests that only work inside of that module.

/cc @ianthehat @heschik
@gopherbot gopherbot added this to the Unreleased milestone Nov 27, 2019
@stamblerre stamblerre modified the milestones: Unreleased, gopls unplanned Dec 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
NeedsFix Tools gopls help wanted
Projects
None yet
Milestone
  gopls unplanned
2 participants
@stamblerre @gopherbot
You can’t perform that action at this time.