Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upx/tools/gopls: add extra testdata in gopls module #35880
Labels
Comments
|
Change https://golang.org/cl/214280 mentions this issue: |
gopherbot
pushed a commit
to golang/tools
that referenced
this issue
Jan 10, 2020
Unfortunately, this can't be tested until golang/go#35880 is resolved, because only the third-party xurls library detects links without schemes. Change-Id: I620581d6ce99c79ae89f3f22ea8ee634c3850a8e Reviewed-on: https://go-review.googlesource.com/c/tools/+/214280 Run-TryBot: Rebecca Stambler <rstambler@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Heschi Kreinick <heschi@google.com>
|
Change https://golang.org/cl/227559 mentions this issue: |
gopherbot
pushed a commit
to golang/tools
that referenced
this issue
Apr 10, 2020
Found golang/go#18824, which helped me understand what to do to fix this issue. Also, changed some of the structure of the code to propagate errors up to the top-level functions. I think this will help us deal with actual errors vs. ignorable errors. Didn't add tests because of golang/go#35880. Just prioritized that issue for gopls/v0.5.0 - it's been biting us a lot lately. Fixes golang/go#38285 Change-Id: I6962462818becb1bcedde4a5be3a2060e71c9389 Reviewed-on: https://go-review.googlesource.com/c/tools/+/227559 Run-TryBot: Rebecca Stambler <rstambler@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Heschi Kreinick <heschi@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
CL 209220 doesn't work because the diff algorithm in
golang.org/x/tools/internal/lspdoesn't support sub-line diffs. We should probably have a way to add extra testdata in thegolang.org/x/tools/goplsso that we can add extra tests that only work inside of that module./cc @ianthehat @heschik