x/net/http2: some tests are hanging on Plan 9 #35904
Closed
Labels
Comments
Change https://golang.org/cl/209417 mentions this issue: |
Change https://golang.org/cl/224217 mentions this issue: |
gopherbot
pushed a commit
that referenced
this issue
Mar 20, 2020
Updates bundled http2 to x/net git rev 63522dbf7 http2: reduce allocations of (*clientConnReadLoop).handleReponse https://golang.org/cl/223783 (#37853) http2: remove unused errors https://golang.org/cl/220458 http2: remove unused stream struct fields https://golang.org/cl/219857 http2: fix typo in comment https://golang.org/cl/214602 http2: workaround TCPConn CloseWrite not being supported on Plan 9 https://golang.org/cl/209417 (#17906, #35904) Change-Id: I0e48f32247938c3858170bf419624367d4faef4b Reviewed-on: https://go-review.googlesource.com/c/go/+/224217 Run-TryBot: Emmanuel Odeke <emm.odeke@gmail.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Ian Lance Taylor <iant@golang.org>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Some tests are hanging and then timing out on the builder (see https://build.golang.org/log/e8cfde2d4ead686a8f9bb892621c1394d7505bce and below). This is due to plan9 not supporting
CloseWrite
on TCP connections. I think we should also callClose
on the connection on plan9, so that tests don't hang and waste time on the builder.@gopherbot add labels OS-Plan9, NeedsFix, Testing
The text was updated successfully, but these errors were encountered: