Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/build/cmd/gitmirror: repo build broken for a while #35944

Closed
bsiegert opened this issue Dec 3, 2019 · 3 comments
Assignees
Labels
Milestone

Comments

@bsiegert
Copy link
Contributor

@bsiegert bsiegert commented Dec 3, 2019

The Git mirroring status on farmer.golang.org has been in an error state for a while. https://farmer.golang.org/status/gitmirror says:

# "gitmirror" status: Git mirroring
# Notes: https://github.com/golang/build/tree/master/cmd/gitmirror
Error: repo build: broken for 179h57m8.359263516s

Maybe this is related to #35120?

/cc @dmitshur @bradfitz

@gopherbot gopherbot added this to the Unreleased milestone Dec 3, 2019
@gopherbot gopherbot added the Builders label Dec 3, 2019
@bradfitz bradfitz self-assigned this Dec 3, 2019
@gopherbot

This comment has been minimized.

Copy link

@gopherbot gopherbot commented Dec 3, 2019

Change https://golang.org/cl/208697 mentions this issue: app, gitmirror, maintner: use maintner for dashboard, not datastore

@bradfitz

This comment has been minimized.

Copy link
Member

@bradfitz bradfitz commented Dec 3, 2019

This is addressed by CL 208697, which removes the mirroring from git to App Engine's datastore.

@dmitshur

This comment has been minimized.

Copy link
Member

@dmitshur dmitshur commented Dec 5, 2019

This issue is the same as #35828.

@dmitshur dmitshur closed this Dec 5, 2019
gopherbot pushed a commit to golang/build that referenced this issue Dec 6, 2019
Historically, the build.golang.org was the entire build system, and it
maintained a parallel copy of that git history in its datastore. It
was always buggy and incomplete and things like force pushes were
scary because the datastore mirror could get out of sync. It was also
a lot of code to support that sync.

This changes build.golang.org to instead get the git history from
maintnerd, and then we can remove all the HTTP handlers around
updating it, and can remove all the gitmirror code to call it to
maintain it.

Now build.golang.org only keeps build results, keyed on the commit
hash. It's much less code, but is still an App Engine app for now.
(but it's getting small enough, that porting it to
cloud.google.com/go/datastore is looking very simple)

This also adds a new "repos" package to unify the configuration of the
various Go repos. There were incomplete & redundant copies all over
the place.

Updates golang/go#34744
Fixes golang/go#35828
Fixes golang/go#31236 (New branch=mixed support adds this when desired)
Fixes golang/go#35944

Change-Id: Ifb39417287df3dea052ba8510566d80b4bc75d51
Reviewed-on: https://go-review.googlesource.com/c/build/+/208697
Reviewed-by: Bryan C. Mills <bcmills@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.