Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/internal/memoize: return error from Get #36004

Open
stamblerre opened this issue Dec 5, 2019 · 1 comment
Open

x/tools/internal/memoize: return error from Get #36004

stamblerre opened this issue Dec 5, 2019 · 1 comment
Labels
Milestone

Comments

@stamblerre
Copy link
Contributor

@stamblerre stamblerre commented Dec 5, 2019

Calling Get on a handle does not propagate an error if the handle is nil, which forces extra logic into clients of this package.

/cc @heschik

@gopherbot gopherbot added this to the Unreleased milestone Dec 5, 2019
@gopherbot gopherbot added the Tools label Dec 5, 2019
@heschik

This comment has been minimized.

Copy link
Contributor

@heschik heschik commented Dec 5, 2019

*if the context is cancelled

@cagedmantis cagedmantis added the NeedsFix label Dec 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.