Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
os: fix Windows (*os.File).Seek on directory handle #36019
Half of our Windows builders (windows-386-2008, windows-amd64-2016, windows-amd64-longtest) fail to seek an *os.File opened on a directory.
But windows-amd64-2008 and windows-amd64-2012 work.
Figure this out and re-enable the test on Windows. (The test was added late in the Go 1.14 cycle, just before beta)
This test was recently added in CL 209961. Apparently Windows can't seek a directory filehandle? And move the test from test/fixedbugs (which is mostly for compiler bugs) to an os package test. Updates #36019 Change-Id: I626b69b0294471014901d0ccfeefe5e2c7651788 Reviewed-on: https://go-review.googlesource.com/c/go/+/210283 Run-TryBot: Brad Fitzpatrick <firstname.lastname@example.org> TryBot-Result: Gobot Gobot <email@example.com> Reviewed-by: Keith Randall <firstname.lastname@example.org>
Yes. But people will still complain that File.Seel(1, os.SeekStart) fails. So, lets not pretend.
Yes, it might work. But is all extra new code worth ability to File.Seek?