net/http: proxied connection can be spuriously closed after dialConn as of CL 210286 #36070
Comments
That CL was the fix for #28012. |
It passed the trybots at the time. Does a js-wasm net.Conn not reliably interrupt a blocked Read on Close or something? I'm fine just skipping that test on js-wasm for now. |
I don't know the underlying cause of the failure. The failure rate seems to be around 50%, which would explain the passing TryBot. |
(CC @neelance @cherrymui for the question about the js-wasm |
The new code in CL 210286 adds a 1 minute timeout reading the CONNECT response if no context deadline was otherwise present. It's possible the net/http tests are just so slow on wasm that it's straddling that 1 minute timeout already (~50% of the time?) with all the parallel tests. But, uh, TestTransportProxy isn't t.Parallel. |
Change https://golang.org/cl/210737 mentions this issue: |
Found the bug, I think: |
Whoops, thanks! |
Change https://golang.org/cl/210738 mentions this issue: |
A timeout in
net/http.TestTransportProxy
seems to have started around CL 210286:2019-12-09T21:50:59-3a3093d/js-wasm
2019-12-09T20:19:32-7d24e95/js-wasm
2019-12-09T16:41:15-a3a630b/js-wasm
CC @bradfitz @ianlancetaylor
The text was updated successfully, but these errors were encountered: