Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/net/http2: test timeouts on js-wasm builder #36088

Open
bcmills opened this issue Dec 11, 2019 · 4 comments
Open

x/net/http2: test timeouts on js-wasm builder #36088

bcmills opened this issue Dec 11, 2019 · 4 comments

Comments

@bcmills
Copy link
Member

@bcmills bcmills commented Dec 11, 2019

2019-12-09T16:08:50-c0dbc17/js-wasm has an interesting timeout failure.

It's not obvious to me whether it is due to a bug in the test, a bug in the js/wasm standard library, or a bug in x/net/http2 or one of its dependencies that happens to be exposed by the different goroutine scheduling on js/wasm.

The presence of a goroutine blocked in net.(*bufferedPipe).Read via crypto/tls makes me suspect a concurrency bug in either golang.org/x/net/http2 or crypto/tls, but admittedly that evidence is not compelling.

I also can't reliably determine how often this occurs or on what platforms because I can't fetch most of the x/net logs (#35515).

CC @bradfitz @FiloSottile @tombergan

@bcmills bcmills added this to the Go1.14 milestone Dec 11, 2019
@bcmills
Copy link
Member Author

@bcmills bcmills commented Dec 11, 2019

The earliest of these failures I could find by manual inspection of the dashboard is https://build.golang.org/log/8d467bcc05d2e38b1b903835bb15858dfc547a62, at CL 208798.

@bcmills
Copy link
Member Author

@bcmills bcmills commented Dec 11, 2019

That's also in TestIssue20704Race rather than TestServer_Push_RejectAfterGoAway, so retitling.

The failure mode is otherwise the same: stuff blocked in golang.org/x/net/http2.readFrameHeader and crypto/tls.(*Conn).Read, and runnable goroutines otherwise. Maybe the tests are just too slow overall on that builder.

@bcmills bcmills changed the title x/net/http2: apparent deadlock in TestServer_Push_RejectAfterGoAway on js-wasm builder x/net/http2: test timeouts on js-wasm builder Dec 11, 2019
@toothrot toothrot modified the milestones: Go1.14, Go1.15 Feb 25, 2020
@ianlancetaylor
Copy link
Contributor

@ianlancetaylor ianlancetaylor commented Jun 15, 2020

CC @neelance in case you haven't seen this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.