Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/build/app/appengine: no way in UI to get to x/foo repo + branch #36117

Closed
bradfitz opened this issue Dec 12, 2019 · 1 comment
Closed

x/build/app/appengine: no way in UI to get to x/foo repo + branch #36117

bradfitz opened this issue Dec 12, 2019 · 1 comment
Labels
Milestone

Comments

@bradfitz
Copy link
Contributor

@bradfitz bradfitz commented Dec 12, 2019

https://build.golang.org/ lets you see other branches via the drop-down,

https://build.golang.org/?branch=release-branch.go1.13

And it lets you see non-go repos via the links at the bottom:

https://build.golang.org/?repo=golang.org%2fx%2fnet

But the branch drop-down on that second link always takes you back to the branch on the main "go" repo, not the repo you were looking at.

And if you manually construct the URL:

https://build.golang.org/?repo=golang.org%2fx%2fnet&branch=release-branch.go1.12

Then it gives you the right results. Note that the top one there is the same as top here:

https://go.googlesource.com/net/+log/refs/heads/release-branch.go1.12

... but its link should be to https://go.googlesource.com/net/+/cdfb69ac37fc6fa907650654115ebebb3aae2087 because Gerrit never saw that git hash due to it being done on a private Gerrit server for a security issue.

@gopherbot gopherbot added this to the Unreleased milestone Dec 12, 2019
@gopherbot gopherbot added the Builders label Dec 12, 2019
@gopherbot
Copy link

@gopherbot gopherbot commented Dec 12, 2019

Change https://golang.org/cl/211138 mentions this issue: app/appengine: don't lose repo arg when switching between branches

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.