Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runtime: "attempt to execute system stack code on user stack" during heap scavenging [1.13 backport] #36127

Closed
gopherbot opened this issue Dec 13, 2019 · 5 comments
Assignees
Milestone

Comments

@gopherbot
Copy link

@gopherbot gopherbot commented Dec 13, 2019

@aclements requested issue #34773 to be considered for backport to the next 1.13 minor release.

@gopherbot, please open a backport to 1.13.

@aclements

This comment has been minimized.

Copy link
Member

@aclements aclements commented Dec 19, 2019

@mknyszek, would you mind preparing a quick backport CL for this?

@mknyszek

This comment has been minimized.

Copy link
Contributor

@mknyszek mknyszek commented Dec 19, 2019

Sorry! Slipped under my radar. On it.

@gopherbot

This comment has been minimized.

Copy link
Author

@gopherbot gopherbot commented Dec 19, 2019

Change https://golang.org/cl/212103 mentions this issue: [release-branch.go1.13] runtime: call goready in wakeScavenger instead of ready

@dmitshur

This comment has been minimized.

Copy link
Member

@dmitshur dmitshur commented Dec 19, 2019

Approving this for Go 1.13 because it is a serious problem (programs may crash when certain rare conditions are met) without a workaround. The fix is small.

This does not need to be backported to Go 1.12 as well because it is not an issue on that release branch.

/cc @toothrot @cagedmantis

gopherbot pushed a commit that referenced this issue Dec 19, 2019
…d of ready

This changes fixes an oversight in wakeScavenger which would cause ready
to be called off of the system stack. This change makes it so that
wakeScavenger calls goready, which switches to the system stack before
calling ready.

Fixes #36127.

Change-Id: Icb13f180b4d8fdd47c921eac1b896e3dd49e43b3
Reviewed-on: https://go-review.googlesource.com/c/go/+/200999
Run-TryBot: Michael Knyszek <mknyszek@google.com>
Reviewed-by: Keith Randall <khr@golang.org>
(cherry picked from commit 2c87be4)
Reviewed-on: https://go-review.googlesource.com/c/go/+/212103
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Austin Clements <austin@google.com>
@gopherbot

This comment has been minimized.

Copy link
Author

@gopherbot gopherbot commented Dec 19, 2019

Closed by merging b0a2a81 to release-branch.go1.13.

@gopherbot gopherbot closed this Dec 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.