testing: failure output format doesn't play nice with emacs compile-mode

[gopherbot]

by ryanb@google.com:

hi! i'll probably look at fixing this in 20% time soon if no one else gets to it first.

What steps will reproduce the problem?

in emacs, run M-x compile and enter "go test" to run a go unit test that fails.

What is the expected output?
What do you see instead?

the failure detail line has a tab at the beginning, which confuses emacs's compile-mode
output parsing. for example:

    app_test.go:32: /generate?... 400 Bad value '' for parameter handles

C-x ` or M-x next-error can't find this. if you remove the tab from the beginning, then
it works.

this is using go-mode.el from dc5e410f0b4c weekly/weekly.2012-03-27, gnu emacs 23.2.1,
goobuntu 10.04.

[gopherbot]

Comment 1 by ryanb@google.com:

looking at decorate() in testing/testing.go, it looks like the leading tab(s) are
intentional, so i'll look at adding to compilation-error-regexp-alist in go-mode.el
instead.

[gopherbot]

Comment 2 by ryanb@google.com:

fix is out for review: http://golang.org/cl/6197091/

[robpike]

Comment 3:

Status changed to Started.

[Sajmani]

Comment 4:

This issue was closed by revision 062b609.

Status changed to Fixed.