Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

testing: failure output format doesn't play nice with emacs compile-mode #3629

Closed
gopherbot opened this issue May 16, 2012 · 4 comments

Comments

Projects
None yet
3 participants
@gopherbot
Copy link

commented May 16, 2012

by ryanb@google.com:

hi! i'll probably look at fixing this in 20% time soon if no one else gets to it first.

What steps will reproduce the problem?

in emacs, run M-x compile and enter "go test" to run a go unit test that fails.

What is the expected output?
What do you see instead?

the failure detail line has a tab at the beginning, which confuses emacs's compile-mode
output parsing. for example:

    app_test.go:32: /generate?... 400 Bad value '' for parameter handles

C-x ` or M-x next-error can't find this. if you remove the tab from the beginning, then
it works.

this is using go-mode.el from dc5e410f0b4c weekly/weekly.2012-03-27, gnu emacs 23.2.1,
goobuntu 10.04.
@gopherbot

This comment has been minimized.

Copy link
Author

commented May 16, 2012

Comment 1 by ryanb@google.com:

looking at decorate() in testing/testing.go, it looks like the leading tab(s) are
intentional, so i'll look at adding to compilation-error-regexp-alist in go-mode.el
instead.
@gopherbot

This comment has been minimized.

Copy link
Author

commented May 16, 2012

Comment 2 by ryanb@google.com:

fix is out for review: http://golang.org/cl/6197091/
@robpike

This comment has been minimized.

Copy link
Contributor

commented Jun 1, 2012

Comment 3:

Status changed to Started.

@Sajmani

This comment has been minimized.

Copy link
Contributor

commented Jun 4, 2012

Comment 4:

This issue was closed by revision 062b609.

Status changed to Fixed.

@gopherbot gopherbot added fixed labels Jun 4, 2012

Sajmani added a commit that referenced this issue May 11, 2015

[release-branch.go1] misc/emacs: make compilation-mode's next-error u…
…nderstand test failure output.

««« backport f469c9d212c4
misc/emacs: make compilation-mode's next-error understand test failure output.

specifically, adds a go-test element to compilation-error-regexp-alist[-alist].
Fixes #3629.

R=golang-dev, rsc, sameer
CC=golang-dev, jba
https://golang.org/cl/6197091

»»»

@golang golang locked and limited conversation to collaborators Jun 24, 2016

This issue was closed.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.