Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/gopls: renaming a test results in diagnostic error from test main #36312

Closed
myitcv opened this issue Dec 30, 2019 · 2 comments
Closed

x/tools/gopls: renaming a test results in diagnostic error from test main #36312

myitcv opened this issue Dec 30, 2019 · 2 comments

Comments

@myitcv
Copy link
Member

@myitcv myitcv commented Dec 30, 2019

What version of Go are you using (go version)?

$ go version
go version devel +dcd3b2c173 Fri Dec 27 14:52:12 2019 +0000 linux/amd64
$ go list -m golang.org/x/tools
golang.org/x/tools v0.0.0-20191227053925-7b8e75db28f4
$ go list -m golang.org/x/tools/gopls
golang.org/x/tools/gopls v0.1.8-0.20191227053925-7b8e75db28f4

Does this issue reproduce with the latest release?

Yes

What operating system and processor architecture are you using (go env)?

go env Output
$ go env
GO111MODULE="on"
GOARCH="amd64"
GOBIN=""
GOCACHE="/home/myitcv/.cache/go-build"
GOENV="/home/myitcv/.config/go/env"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOINSECURE=""
GONOPROXY=""
GONOSUMDB=""
GOOS="linux"
GOPATH="/home/myitcv/gostuff"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/home/myitcv/gos"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/home/myitcv/gos/pkg/tool/linux_amd64"
GCCGO="gccgo"
AR="ar"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
GOMOD="/home/myitcv/gostuff/src/github.com/myitcv/govim/go.mod"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build741613824=/tmp/go-build -gno-record-gcc-switches"

What did you do?

Create these minimal files:

-- go.mod --
module mod.com

go 1.14

-- main.go --
package main

-- main_test.go --
package main

import "testing"

func TestThis(t *testing.T) {
}

Now quit your editor (such that gopls closes) and run:

go test

Now re-open your editor, open main_test.go and rename TestThis -> TestThisAgain

What did you expect to see?

No diagnostic errors.

What did you see instead?

Diagnostic error:

../../../../../.cache/go-build/9f/9f968e31138f43c5fd9fed9301f8c7895438d8a00b51baf3411218dad5311e4b-d|22 col 21| TestThis not declared by package main

cc @stamblerre

@gopherbot gopherbot added this to the Unreleased milestone Dec 30, 2019
@gopherbot gopherbot added the Tools label Dec 30, 2019
@stamblerre stamblerre modified the milestones: Unreleased, gopls v1.0 Dec 30, 2019
@stamblerre

This comment has been minimized.

Copy link
Contributor

@stamblerre stamblerre commented Jan 9, 2020

https://golang.org/cl/213660 just added the behavior to ignore test mains. Are you still seeing this issue with that CL?

@myitcv

This comment has been minimized.

Copy link
Member Author

@myitcv myitcv commented Jan 10, 2020

Thanks, that appears to fix it.

@myitcv myitcv closed this Jan 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.