Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/gopls: unimported completions add circular dependencies #36321

Closed
stamblerre opened this issue Dec 30, 2019 · 1 comment
Closed

x/tools/gopls: unimported completions add circular dependencies #36321

stamblerre opened this issue Dec 30, 2019 · 1 comment
Assignees
Milestone

Comments

@stamblerre
Copy link
Contributor

@stamblerre stamblerre commented Dec 30, 2019

/cc @heschik

I know that this has been fixed in standard goimports, but we need the analogous fix for unimported completions in gopls.

@gopherbot gopherbot added this to the Unreleased milestone Dec 30, 2019
@heschik heschik self-assigned this Dec 30, 2019
@gopherbot
Copy link

@gopherbot gopherbot commented Dec 30, 2019

Change https://golang.org/cl/212897 mentions this issue: internal/imports: filter out self-import completions

@golang golang locked and limited conversation to collaborators Dec 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.