Skip to content

/ go

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/gopls: channels are not ranked highest in parameters to close #36326

Closed
stamblerre opened this issue Dec 30, 2019 · 1 comment
Closed

x/tools/gopls: channels are not ranked highest in parameters to close #36326

stamblerre opened this issue Dec 30, 2019 · 1 comment
Labels
Tools gopls
Milestone
gopls/v1.0.0

Comments

@stamblerre
Copy link
Contributor

@stamblerre stamblerre commented Dec 30, 2019 •
edited

Repro:

package main

var xb chan int

func xa() int { return 0 }

func main() {
	close(<>)
}

xa will be ranked above xb.

/cc @muirdm
@gopherbot gopherbot added this to the Unreleased milestone Dec 30, 2019
@stamblerre stamblerre modified the milestones: Unreleased, gopls v1.0 Dec 30, 2019
@gopherbot

This comment has been minimized.

Sign in to view
Copy link

@gopherbot gopherbot commented Dec 31, 2019

Change https://golang.org/cl/212957 mentions this issue: internal/lsp/source: improve completion support for args to builtins
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Tools gopls
Projects
None yet
Milestone
  gopls/v1.0.0
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
@stamblerre @gopherbot
You can’t perform that action at this time.