time: package has two different arrays with long month names

[petar-dambovaliev]

What version of Go are you using (go version)?

go version go1.13.1 linux/amd64

Seems to me that there doesn't need to be code duplication here.
Do you mind if i remove it?

https://github.com/golang/go/blame/master/src/time/time.go#L288
https://github.com/golang/go/blame/master/src/time/format.go#L321

[ALTree]

For something this small, I would just send a patch. It'll get reviewed (and accepted, or rejected) directly on gerrit.

[mariush-github]

While you're in format.go , the shortDayNames array (line 296) could also be removed, if you reuse the longDayNames and take the first 3 characters - in this case it happens to match for all days.

Same for shortMonthNames array, seems like all 3 letter months have the same first 3 letters as in longMonthNames

also time.go: 326 there's a days array , format.go : 286 has longDayNames array

[petar-dambovaliev]

While you're in format.go , the shortDayNames array (line 296) could also be removed, if you reuse the longDayNames and take the first 3 characters - in this case it happens to match for all days.

Same for shortMonthNames array, seems like all 3 letter months have the same first 3 letters as in longMonthNames

also time.go: 326 there's a days array , format.go : 286 has longDayNames array

Cool, i will get on it.
Although, i would be against removing the short names. It would cause runtime overhead.

[gopherbot]

Change https://golang.org/cl/213177 mentions this issue: time: remove code duplication