Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upruntime: sweep increased allocation count crash on arm64 [1.13 backport] #36361
Comments
This comment has been minimized.
This comment has been minimized.
|
Change https://golang.org/cl/213683 mentions this issue: |
This comment has been minimized.
This comment has been minimized.
|
Approving as this is a serious problem with no workaround. |
This comment has been minimized.
This comment has been minimized.
|
Closed by merging acc723a to release-branch.go1.13. |
gopherbot
pushed a commit
that referenced
this issue
Jan 8, 2020
…lly on ARM64 If a pointer write is not atomic, if the GC is running concurrently, it may observe a partially updated pointer, which may point to unallocated or already dead memory. Most pointer writes, like the store instructions generated by the compiler, are already atomic. But we still need to be careful in places like memmove. In memmove, we don't know which bits are pointers (or too expensive to query), so we ensure that all aligned pointer-sized units are written atomically. Fixes #36361. Updates #36101. Change-Id: I1b3ca24c6b1ac8a8aaf9ee470115e9a89ec1b00b Reviewed-on: https://go-review.googlesource.com/c/go/+/212626 Reviewed-by: Austin Clements <austin@google.com> (cherry picked from commit ffbc027) Reviewed-on: https://go-review.googlesource.com/c/go/+/213683 Run-TryBot: Cherry Zhang <cherryyz@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
@aclements requested issue #36101 to be considered for backport to the next 1.13 minor release.