Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/gopls: extra autocompletion after complete keyword #36363

Closed
stamblerre opened this issue Jan 2, 2020 · 2 comments
Closed

x/tools/gopls: extra autocompletion after complete keyword #36363

stamblerre opened this issue Jan 2, 2020 · 2 comments
Labels
Milestone

Comments

@stamblerre
Copy link
Contributor

@stamblerre stamblerre commented Jan 2, 2020

Screen Shot 2020-01-02 at 1 44 57 PM

In this example, the full keyword true was typed, but it was still the 3rd ranked completion, which results in VS Code auto-inserting it if a user hits enter (intending to go to the next line).

/cc @muirdm

@gopherbot gopherbot added this to the Unreleased milestone Jan 2, 2020
@muirdm

This comment has been minimized.

Copy link

@muirdm muirdm commented Jan 2, 2020

Yeah I've been meaning to fix this. It is because true is an untyped bool which gets a score penalty. I'll fix it to not penalize builtin constants.

@gopherbot

This comment has been minimized.

Copy link

@gopherbot gopherbot commented Jan 2, 2020

Change https://golang.org/cl/213137 mentions this issue: internal/lsp/source: don't dowrank builtin constant completions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.