Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runtime: sweep increased allocation count crash on arm64 [1.12 backport] #36367

aclements opened this issue Jan 2, 2020 · 3 comments

runtime: sweep increased allocation count crash on arm64 [1.12 backport] #36367

aclements opened this issue Jan 2, 2020 · 3 comments
CherryPickApproved FrozenDueToAge


Copy link

@aclements aclements commented Jan 2, 2020

Issue #36101 should be considered for backport to the next 1.12 minor release.

@aclements aclements added the CherryPickCandidate label Jan 2, 2020
@aclements aclements added this to the Go1.12.15 milestone Jan 2, 2020
Copy link

@gopherbot gopherbot commented Jan 7, 2020

Change mentions this issue: [release-branch.go1.12] runtime: ensure memmove write pointer atomically on ARM64

Copy link

@toothrot toothrot commented Jan 8, 2020

Approving as this is a serious problem with no workaround.

@toothrot toothrot added CherryPickApproved and removed CherryPickCandidate labels Jan 8, 2020
Copy link

@gopherbot gopherbot commented Jan 8, 2020

Closed by merging ae78084 to release-branch.go1.12.

gopherbot pushed a commit that referenced this issue Jan 8, 2020
…lly on ARM64

If a pointer write is not atomic, if the GC is running
concurrently, it may observe a partially updated pointer, which
may point to unallocated or already dead memory. Most pointer
writes, like the store instructions generated by the compiler,
are already atomic. But we still need to be careful in places
like memmove. In memmove, we don't know which bits are pointers
(or too expensive to query), so we ensure that all aligned
pointer-sized units are written atomically.

Fixes #36367.
Updates #36101.

Change-Id: I1b3ca24c6b1ac8a8aaf9ee470115e9a89ec1b00b
Reviewed-by: Austin Clements <>
(cherry picked from commit ffbc027)
Run-TryBot: Cherry Zhang <>
TryBot-Result: Gobot Gobot <>
@golang golang locked and limited conversation to collaborators Jan 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
CherryPickApproved FrozenDueToAge
None yet

No branches or pull requests

4 participants