Skip to content

/ go

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net/http: Allow upgrading connections even if DisableKeepAlives is set #36381

Open
nhooyr opened this issue Jan 4, 2020 · 1 comment · May be fixed by #36382
Open

net/http: Allow upgrading connections even if DisableKeepAlives is set #36381

nhooyr opened this issue Jan 4, 2020 · 1 comment · May be fixed by #36382
Labels
NeedsFix
Milestone
Backlog

Comments

@nhooyr
Copy link
Contributor

@nhooyr nhooyr commented Jan 4, 2020

If the http transport has DisableKeepAlives enabled, then connection upgrading does not work. See nhooyr/websocket#185

If DisableKeepAlives is set, then the client sets Connection: close on every request which is completely fine.

The problem is that when the server encounters such a request, it prevents any http.Handler from setting the Connection header.

See

go/src/net/http/server.go

Line 1293 in 3a6cd4c

} else if !w.req.ProtoAtLeast(1, 1) || w.wantsClose {

If that is changed to:

	} else if !w.req.ProtoAtLeast(1, 1) ||
		// Only close if the request indicates the client wants to close
		// and we are not upgrading the connection.
		(w.wantsClose && header.get("Connection") != "Upgrade") {
		w.closeAfterReply = true
	}

Then everything works fine.
@nhooyr nhooyr mentioned this issue Jan 4, 2020
Closed
nhooyr added a commit to nhooyr/go that referenced this issue Jan 4, 2020
@nhooyr
net/http: Allow upgrading non keepalive connections
Verified
This commit was signed with a verified signature.
nhooyr Anmol Sethi
GPG key ID: 8CEF1878FF10ADEB Learn about signing commits
8019ed4 
Closes golang#36381
nhooyr added a commit to nhooyr/go that referenced this issue Jan 4, 2020
@nhooyr
net/http: allow upgrading non keepalive connections
Verified
This commit was signed with a verified signature.
nhooyr Anmol Sethi
GPG key ID: 8CEF1878FF10ADEB Learn about signing commits
1a74c9e 
Fixes golang#36381
@nhooyr nhooyr linked a pull request that will close this issue Jan 4, 2020
Open
@gopherbot

This comment has been minimized.

Sign in to view
Copy link

@gopherbot gopherbot commented Jan 4, 2020

Change https://golang.org/cl/213277 mentions this issue: net/http: allow upgrading non keepalive connections
nhooyr added a commit to nhooyr/go that referenced this issue Jan 6, 2020
@nhooyr
net/http: allow upgrading non keepalive connections
Verified
This commit was signed with a verified signature.
nhooyr Anmol Sethi
GPG key ID: 8CEF1878FF10ADEB Learn about signing commits
f7fcdcf 
Fixes golang#36381
nhooyr added a commit to nhooyr/go that referenced this issue Jan 7, 2020
@nhooyr
net/http: allow upgrading non keepalive connections
Verified
This commit was signed with a verified signature.
nhooyr Anmol Sethi
GPG key ID: 8CEF1878FF10ADEB Learn about signing commits
67084c3 
Fixes golang#36381
nhooyr added a commit to nhooyr/go that referenced this issue Jan 7, 2020
@nhooyr
net/http: allow upgrading non keepalive connections
Verified
This commit was signed with a verified signature.
nhooyr Anmol Sethi
GPG key ID: 8CEF1878FF10ADEB Learn about signing commits
fa35c25 
Fixes golang#36381
nhooyr added a commit to nhooyr/go that referenced this issue Jan 7, 2020
@nhooyr
net/http: allow upgrading non keepalive connections
Verified
This commit was signed with a verified signature.
nhooyr Anmol Sethi
GPG key ID: 8CEF1878FF10ADEB Learn about signing commits
45fe378 
Fixes golang#36381

If one was using http.Transport with DisableKeepAlives and trying
to upgrade a connection against net/http's Server, the Server
would not allow a "Connection: Upgrade" header to be written
and instead override it to "Connection: Close" which would
break the handshake.

This commit ensures net/http's Server does not override the
connection header for successful protocol switch responses.
nhooyr added a commit to nhooyr/go that referenced this issue Jan 7, 2020
@nhooyr
net/http: allow upgrading non keepalive connections
Verified
This commit was signed with a verified signature.
nhooyr Anmol Sethi
GPG key ID: 8CEF1878FF10ADEB Learn about signing commits
df639f8 
Fixes golang#36381

If one was using http.Transport with DisableKeepAlives and trying
to upgrade a connection against net/http's Server, the Server
would not allow a "Connection: Upgrade" header to be written
and instead override it to "Connection: Close" which would
break the handshake.

This commit ensures net/http's Server does not override the
connection header for successful protocol switch responses.
@toothrot toothrot added the NeedsFix label Jan 7, 2020
@toothrot toothrot added this to the Backlog milestone Jan 7, 2020
nhooyr added a commit to nhooyr/go that referenced this issue Jan 7, 2020
@nhooyr
net/http: allow upgrading non keepalive connections
Verified
This commit was signed with a verified signature.
nhooyr Anmol Sethi
GPG key ID: 8CEF1878FF10ADEB Learn about signing commits
dbb003f 
Fixes golang#36381

If one was using http.Transport with DisableKeepAlives and trying
to upgrade a connection against net/http's Server, the Server
would not allow a "Connection: Upgrade" header to be written
and instead override it to "Connection: Close" which would
break the handshake.

This commit ensures net/http's Server does not override the
connection header for successful protocol switch responses.
nhooyr added a commit to nhooyr/go that referenced this issue Jan 9, 2020
@nhooyr
net/http: allow upgrading non keepalive connections
Verified
This commit was signed with a verified signature.
nhooyr Anmol Sethi
GPG key ID: 8CEF1878FF10ADEB Learn about signing commits
716912d 
Fixes golang#36381

If one was using http.Transport with DisableKeepAlives and trying
to upgrade a connection against net/http's Server, the Server
would not allow a "Connection: Upgrade" header to be written
and instead override it to "Connection: Close" which would
break the handshake.

This commit ensures net/http's Server does not override the
connection header for successful protocol switch responses.
nhooyr added a commit to nhooyr/go that referenced this issue Jan 9, 2020
@nhooyr
net/http: allow upgrading non keepalive connections
Verified
This commit was signed with a verified signature.
nhooyr Anmol Sethi
GPG key ID: 8CEF1878FF10ADEB Learn about signing commits
80325a2 
Fixes golang#36381

If one was using http.Transport with DisableKeepAlives and trying
to upgrade a connection against net/http's Server, the Server
would not allow a "Connection: Upgrade" header to be written
and instead override it to "Connection: Close" which would
break the handshake.

This commit ensures net/http's Server does not override the
connection header for successful protocol switch responses.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
NeedsFix
Projects
None yet
Milestone
  Backlog
3 participants
@nhooyr @gopherbot @toothrot
You can’t perform that action at this time.