Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/vet: printf analysis missing support for %O #36385

Closed
perillo opened this issue Jan 4, 2020 · 2 comments
Closed

cmd/vet: printf analysis missing support for %O #36385

perillo opened this issue Jan 4, 2020 · 2 comments

Comments

@perillo
Copy link

@perillo perillo commented Jan 4, 2020

What version of Go are you using (go version)?

$ go version
go version go1.13.5 linux/amd64

Does this issue reproduce with the latest release?

Yes

What operating system and processor architecture are you using (go env)?

go env Output
$ go env
GO111MODULE="auto"
GOARCH="amd64"
GOBIN="/home/manlio/.local/bin"
GOCACHE="/home/manlio/.cache/go-build"
GOENV="/home/manlio/.config/go/env"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GONOPROXY=""
GONOSUMDB=""
GOOS="linux"
GOPATH="/home/manlio/.local/lib/go:/home/manlio/src/go"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/usr/lib/go"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/usr/lib/go/pkg/tool/linux_amd64"
GCCGO="gccgo"
AR="ar"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
GOMOD=""
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build809721096=/tmp/go-build -gno-record-gcc-switches"
GOROOT/bin/go version: go version go1.13.5 linux/amd64
GOROOT/bin/go tool compile -V: compile version go1.13.5
uname -sr: Linux 5.4.6-arch3-1
/usr/lib/libc.so.6: GNU C Library (GNU libc) stable release version 2.30.
gdb --version: GNU gdb (GDB) 8.3.1

What did you do?

https://play.golang.org/p/unIQ7japybX

What did you expect to see?

The output of the program

0o755

Ideally, go vet should report that the constant 0755 is suspicious, and should suggest to rewrite it as 0o755.

What did you see instead?

The error reported by go vet

Printf format %O has unknown verb O
@perillo perillo changed the title vet: printf format has unknown verb O cmd/vet: printf format has unknown verb O Jan 4, 2020
@robpike robpike changed the title cmd/vet: printf format has unknown verb O cmd/vet: printf analysis missing support for %O Jan 4, 2020
@robpike

This comment has been minimized.

Copy link
Contributor

@robpike robpike commented Jan 4, 2020

Indeed, golang.org/x/tools/go/analysis/passes/printf/printf.go is missing the 'O' verb.

@toothrot

This comment has been minimized.

Copy link
Contributor

@toothrot toothrot commented Jan 7, 2020

This seems like a duplicate of #29986. I will close this issue in favor of that one. Please let me know if I am mistaken.

@toothrot toothrot closed this Jan 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.