Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

database/sql: inconsistent parameter handling #3640

Closed
LukeMauldin opened this issue May 18, 2012 · 3 comments
Closed

database/sql: inconsistent parameter handling #3640

LukeMauldin opened this issue May 18, 2012 · 3 comments
Assignees

Comments

@LukeMauldin
Copy link

@LukeMauldin LukeMauldin commented May 18, 2012

Referring to http://golang.org/src/pkg/database/sql/sql.go

func (s *Stmt) Exec(args ...interface{}) (line 663) checks for
si.(driver.ColumnConverter) to convert args to subtypes.  

However, a very similar function: func (s *Stmt) Query(args ...interface{}) (line 796)
does not check to see if the statement implements driver.ColumnConvert.  According to
the documentation, it looks like the Exec function is correct and that the Query
function should be updated.
@bradfitz
Copy link
Contributor

@bradfitz bradfitz commented May 24, 2012

Comment 1:

Owner changed to @bradfitz.

Status changed to Accepted.

@bradfitz
Copy link
Contributor

@bradfitz bradfitz commented May 24, 2012

Comment 2:

Patch here: http://golang.org/cl/6258045
@bradfitz
Copy link
Contributor

@bradfitz bradfitz commented May 29, 2012

Comment 3:

This issue was closed by revision 93fe8c0.

Status changed to Fixed.

@golang golang locked and limited conversation to collaborators Jun 24, 2016
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.