Skip to content

/ go

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net/http: racing write to t.ProxyConnectHeader in dialConn when proxy URL includes auth credentials [1.13 backport] #36434

Closed
gopherbot opened this issue Jan 7, 2020 · 2 comments
Closed

net/http: racing write to t.ProxyConnectHeader in dialConn when proxy URL includes auth credentials [1.13 backport] #36434

gopherbot opened this issue Jan 7, 2020 · 2 comments
Labels
CherryPickApproved
Milestone
Go1.13.6

Comments

@gopherbot
Copy link

@gopherbot gopherbot commented Jan 7, 2020

@bcmills requested issue #36431 to be considered for backport to the next 1.13 minor release.

@gopherbot, please backport to Go 1.13 and 1.12.

This is a data race in net/http, and the fix is straightforward.
@gopherbot gopherbot mentioned this issue Jan 7, 2020
Closed
@gopherbot gopherbot added this to the Go1.13.6 milestone Jan 7, 2020
@gopherbot

This comment has been minimized.

Sign in to view
Copy link
Author

@gopherbot gopherbot commented Jan 7, 2020

Change https://golang.org/cl/213657 mentions this issue: [release-branch.go1.13] net/http: avoid writing to Transport.ProxyConnectHeader
@gopherbot

This comment has been minimized.

Sign in to view
Copy link
Author

@gopherbot gopherbot commented Jan 7, 2020

Closed by merging 367da16 to release-branch.go1.13.
@gopherbot gopherbot closed this Jan 7, 2020
gopherbot pushed a commit that referenced this issue Jan 7, 2020
@bcmills
[release-branch.go1.13] net/http: avoid writing to Transport.ProxyCon…
367da16 
…nectHeader

Previously, we accidentally wrote the Proxy-Authorization header for
the initial CONNECT request to the shared ProxyConnectHeader map when
it was non-nil.

Updates #36431
Fixes #36434

Change-Id: I5cb414f391dddf8c23d85427eb6973f14c949025
Reviewed-on: https://go-review.googlesource.com/c/go/+/213638
Run-TryBot: Bryan C. Mills <bcmills@google.com>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
(cherry picked from commit 249c85d)
Reviewed-on: https://go-review.googlesource.com/c/go/+/213657
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
CherryPickApproved
Projects
None yet
Milestone
  Go1.13.6
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
@gopherbot @bradfitz
You can’t perform that action at this time.