net/http: racing write to t.ProxyConnectHeader in dialConn when proxy URL includes auth credentials [1.13 backport] #36434
Labels
Milestone
Comments
Change https://golang.org/cl/213657 mentions this issue: |
Closed by merging 367da16 to release-branch.go1.13. |
gopherbot
pushed a commit
that referenced
this issue
Jan 7, 2020
…nectHeader Previously, we accidentally wrote the Proxy-Authorization header for the initial CONNECT request to the shared ProxyConnectHeader map when it was non-nil. Updates #36431 Fixes #36434 Change-Id: I5cb414f391dddf8c23d85427eb6973f14c949025 Reviewed-on: https://go-review.googlesource.com/c/go/+/213638 Run-TryBot: Bryan C. Mills <bcmills@google.com> Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> (cherry picked from commit 249c85d) Reviewed-on: https://go-review.googlesource.com/c/go/+/213657
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
@bcmills requested issue #36431 to be considered for backport to the next 1.13 minor release.
The text was updated successfully, but these errors were encountered: