net/http: http Client regression

[bradfitz]

Change 820ffde8c396 for issue #1967 broke the http client:

func TestIssueNNNN(t *testing.T) {
        ts := httptest.NewServer(HandlerFunc(func(w ResponseWriter, r *Request) {
                w.Header().Set("Connection", "close")
                for i := 0; i < 1024; i++ {
                        w.Write([]byte("foo "))
                }
        }))
        defer ts.Close()
        tr := &Transport{}
        c := &Client{Transport: tr}
        res, err := c.Get(ts.URL)
        if err != nil {
                t.Fatal(err)
        }
        defer res.Body.Close()
        bs, err := ioutil.ReadAll(res.Body)
        if err != nil {
                t.Fatal(err)    // <--- Fails, "use of closed network connection"
        }
        if len(bs) != 1024 * len("foo ") {
                t.Errorf("unexpected response length")
        }
}

(report from cookieo9@gmail.com)

[bradfitz]

Comment 1:

This issue was closed by revision 30c0d23.

Status changed to Fixed.

[bradfitz]

Comment 2:

This issue was closed by revision 30c0d23.