Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/build: stop testing playground against Go 1.12 #36464

Closed
bradfitz opened this issue Jan 8, 2020 · 2 comments
Closed

x/build: stop testing playground against Go 1.12 #36464

bradfitz opened this issue Jan 8, 2020 · 2 comments
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Unreleased

Comments

@bradfitz
Copy link
Contributor

bradfitz commented Jan 8, 2020

Running TryBots on x/playground showed failures with Go 1.12:

https://go-review.googlesource.com/c/playground/+/195983/17#message-343e7848e33f278f95e4672848606973671a6203

We don't need to be testing Go 1.12 there.
@gopherbot gopherbot added this to the Unreleased milestone Jan 8, 2020
@gopherbot gopherbot added the Builders x/build issues (builders, bots, dashboards) label Jan 8, 2020
@toothrot toothrot added the NeedsFix The path to resolution is known, but the work has not been done. label Jan 9, 2020
@toothrot toothrot self-assigned this Feb 26, 2020
@dmitshur
Copy link
Contributor

I believe this is resolved now, because Go 1.14 is out, so only 1.14 and 1.13 are being tested.

@toothrot Do you think anything more needs to be done, or can we close this?

@toothrot
Copy link
Contributor

This is fixed by work done for #25224.

@golang golang locked and limited conversation to collaborators Apr 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
4 participants
@bradfitz @toothrot @dmitshur @gopherbot