Skip to content

/ go

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/gopls: centralize all "go env X" calls #36487

Closed
stamblerre opened this issue Jan 9, 2020 · 1 comment
Closed

x/tools/gopls: centralize all "go env X" calls #36487

stamblerre opened this issue Jan 9, 2020 · 1 comment
Labels
NeedsFix Tools gopls
Milestone
gopls/v0.4.0

Comments

@stamblerre
Copy link
Contributor

@stamblerre stamblerre commented Jan 9, 2020 •
edited

We've started relying on a number of calls to go env to build up various pieces of the view. At minimum right now, we call go env GOPATH for the goimports process env function, go env GOMOD for the -modfile handling, and now go env GOCACHE to detect test mains. All of these should be consolidated into a single go env call that happens on view creation.
@gopherbot gopherbot added this to the Unreleased milestone Jan 9, 2020
@stamblerre stamblerre added the NeedsFix label Jan 9, 2020
@stamblerre stamblerre modified the milestones: Unreleased, gopls v1.0 Jan 9, 2020
@gopherbot
Copy link

@gopherbot gopherbot commented Jan 12, 2020

Change https://golang.org/cl/214417 mentions this issue: internal/lsp: push initialization tasks into one function
@stamblerre stamblerre modified the milestones: gopls/v1.0.0, gopls/v0.4.0 Jul 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
NeedsFix Tools gopls
Projects
None yet
Milestone
gopls/v0.4.0
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
@stamblerre @gopherbot