Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/gopls: -modfile flag check returns errors for Go 1.13 #36488

Closed
stamblerre opened this issue Jan 9, 2020 · 1 comment
Closed

x/tools/gopls: -modfile flag check returns errors for Go 1.13 #36488

stamblerre opened this issue Jan 9, 2020 · 1 comment
Assignees
Labels
Milestone

Comments

@stamblerre
Copy link
Contributor

@stamblerre stamblerre commented Jan 9, 2020

I'm using Go 1.13, and I'm noticing errors pop up in my gopls logs, as well as a single publishDiagnostic with no URI and no diagnostics. I've traced the error back to this. When I run GO111MODULE=off go list -f '{{range context.ReleaseTags}}{{if eq . "go1.14"}}{{.}}{{end}}{{end}}' in my directory, I get no stdout at all. My guess is that the check for the stdout should be more lenient.

We should also track down how an empty diagnostic with no URI gets sent.

/cc @ridersofrohan

@gopherbot gopherbot added this to the Unreleased milestone Jan 9, 2020
@ridersofrohan ridersofrohan self-assigned this Jan 10, 2020
@gopherbot

This comment has been minimized.

Copy link

@gopherbot gopherbot commented Jan 10, 2020

Change https://golang.org/cl/214290 mentions this issue: internal/lsp: change go1.14 check to be more lenient

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.