Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/build: should not be testing x/mobile on freebsd/386 on Go 1.12 #36506

Closed
dmitshur opened this issue Jan 10, 2020 · 3 comments
Closed

x/build: should not be testing x/mobile on freebsd/386 on Go 1.12 #36506

dmitshur opened this issue Jan 10, 2020 · 3 comments
Assignees
Milestone

Comments

@dmitshur
Copy link
Member

@dmitshur dmitshur commented Jan 10, 2020

image

Sample build link is https://build.golang.org/log/46ff9239d847eedc57081fb7d1580a4b01de0e05. The test fails because golang.org/x/mobile/exp/sensor and golang.org/x/mobile/gl packages fail to build due to missing identifiers.

This looks like a misconfiguration in x/build. The x/mobile repo tests are running on tip on a very few builders. They're not running at all for Go 1.13. And they're only running for a few freebsd/386 configurations on Go 1.12.

The fix is to disable these builders from running.

/cc @hyangah @bradfitz @cagedmantis @toothrot

@dmitshur dmitshur added this to the Unreleased milestone Jan 10, 2020
@gopherbot gopherbot added the mobile label Jan 10, 2020
@dmitshur dmitshur changed the title x/mobile/cmd/gobind: TestGobind failing on Go 1.12 x/build: should not be testing x/mobile on freebsd/386 on Go 1.12 Jan 10, 2020
@dmitshur dmitshur self-assigned this Jan 10, 2020
@gopherbot

This comment has been minimized.

Copy link

@gopherbot gopherbot commented Jan 10, 2020

Change https://golang.org/cl/214293 mentions this issue: dashboard: remove explicit support for release-branch.go1.11

@gopherbot

This comment has been minimized.

Copy link

@gopherbot gopherbot commented Jan 10, 2020

Change https://golang.org/cl/214294 mentions this issue: dashboard: include default builds policy in freebsd-386-* builders

gopherbot pushed a commit to golang/build that referenced this issue Jan 10, 2020
We do not support Go 1.11 by now, so there is no longer a need to
include filtering for release-branch.go1.11. Remove it to simplify
code and remove useless test cases.

There was a bug where the buildsRepo policy for freebsd-386-10_3,
freebsd-386-10_4, and freebsd-386-11_1 builders forgot to include
the default build policy, so it was testing x/mobile unintentionally.
Add a test case for its current behavior. It'll be fixed in next CL.

Updates golang/go#36506

Change-Id: I4b2ff6cae417bf4699ec99f5c427b8531e12e915
Reviewed-on: https://go-review.googlesource.com/c/build/+/214293
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Alexander Rakoczy <alex@golang.org>
@dmitshur

This comment has been minimized.

Copy link
Member Author

@dmitshur dmitshur commented Jan 14, 2020

The relevant components are redeployed by now. This is the new current state for posterity:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.