Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proposal: net/http: add check for SameSite client incompatibility #36539

Closed
jeffdupont opened this issue Jan 13, 2020 · 6 comments
Closed

proposal: net/http: add check for SameSite client incompatibility #36539

jeffdupont opened this issue Jan 13, 2020 · 6 comments

Comments

@jeffdupont
Copy link
Contributor

@jeffdupont jeffdupont commented Jan 13, 2020

I'm looking to implement a helper method based on the SameSite known incompatible clients.

https://www.chromium.org/updates/same-site/incompatible-clients

@gopherbot

This comment has been minimized.

Copy link

@gopherbot gopherbot commented Jan 13, 2020

Change https://golang.org/cl/214600 mentions this issue: http: add support to determine if client supports the SameSite cookie parameter

@jeffdupont jeffdupont changed the title Cookie helper for SameSite useragent incompatibility Check for SameSite Client incompatibility Jan 13, 2020
@jeffdupont jeffdupont changed the title Check for SameSite Client incompatibility Check for SameSite client incompatibility Jan 13, 2020
@smasher164 smasher164 changed the title Check for SameSite client incompatibility net/http: add check for SameSite client incompatibility Jan 14, 2020
@smasher164 smasher164 changed the title net/http: add check for SameSite client incompatibility proposal: net/http: add check for SameSite client incompatibility Jan 14, 2020
@gopherbot gopherbot added this to the Proposal milestone Jan 14, 2020
@gopherbot gopherbot added the Proposal label Jan 14, 2020
@smasher164

This comment has been minimized.

Copy link
Member

@smasher164 smasher164 commented Jan 14, 2020

Since this is very user-agent-specific, I'm not sure that net/http is the best place for this to leave (based off the CL). An external library or maybe x/net might suit this feature better. /cc @bradfitz

@jeffdupont

This comment has been minimized.

Copy link
Contributor Author

@jeffdupont jeffdupont commented Jan 14, 2020

@bradfitz

This comment has been minimized.

Copy link
Contributor

@bradfitz bradfitz commented Jan 14, 2020

Sorry, we don't want to go down the road of adding user agent sniffing APIs to the standard library. That's a huge maintenance burden, somewhat frail, and arguably not good for the web.

This can live elsewhere, of course. (https://golang.org/doc/faq#x_in_std)

@bradfitz bradfitz closed this Jan 14, 2020
@bradfitz

This comment has been minimized.

Copy link
Contributor

@bradfitz bradfitz commented Jan 14, 2020

Also: https://groups.google.com/a/chromium.org/forum/m/#!msg/blink-dev/-2JIRNMWJ7s/yHe4tQNLCgAJ ("Intent to Deprecate and Freeze: The User-Agent string")

@jeffdupont

This comment has been minimized.

Copy link
Contributor Author

@jeffdupont jeffdupont commented Jan 14, 2020

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.