Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/crypto/acme/autocert: Manager.RenewBefore must be >1hour #36548

leitzler opened this issue Jan 14, 2020 · 1 comment

x/crypto/acme/autocert: Manager.RenewBefore must be >1hour #36548

leitzler opened this issue Jan 14, 2020 · 1 comment


Copy link

@leitzler leitzler commented Jan 14, 2020

What version of Go are you using (go version)?

$ go version
go version go1.13.6 linux/amd64
$ go list -m v0.0.0-20200109152110-61a87790db17

Does this issue reproduce with the latest release?


What did you do?

Used a Manager with RenewBefore set to 5 minutes (as a part of a test while running my own boulder instance):

m := autocert.Manager{
    // ...
    RenewBefore: time.Minute * 5,

What did you expect to see?

I expected that the manager actually used 5 minutes as RenewBefore, since the documentation states:

// RenewBefore optionally specifies how early certificates should
// be renewed before they expire.
// If zero, they're renewed 30 days before expiration.
RenewBefore time.Duration

What did you see instead?

RenewBefore being set to 30 days.

There is a check that makes sure that the value specified is more than the renewJitter (1 hour):

Either it should be allowed to use values less than one hour, or the documentation should reflect that values less than an hour is the same thing as "30 days".

@gopherbot gopherbot added this to the Unreleased milestone Jan 14, 2020
@cagedmantis cagedmantis modified the milestones: Unreleased, Backlog Jan 14, 2020
Copy link

@cagedmantis cagedmantis commented Jan 14, 2020

@FiloSottile FiloSottile modified the milestones: Backlog, Unreleased Oct 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants