I made a mistake in gopls (corrected in CL 214717), which resulted in us passing multiple package paths as one argument to go list. The resulting error message did not make this easy to debug, as it wasn't clear that that was the issue.
-: module golang.org/x/tools@latest found (v0.0.0-20200114052453-d31a08c2edf2), but does not contain package golang.org/x/tools/internal/lsp/noparse_format golang.org/x/tools/internal/lsp/folding
It should be pretty obvious that a package path with a space is invalid, but it's not obvious what's going wrong from the error message.
The text was updated successfully, but these errors were encountered:
We should do more validation of package paths. We should decide exactly what should be allowed in package paths before tightening that up though. golang.org/x/mod/module.CheckImportPath is very restrictive, and it may break some projects if we use it as-is.