Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/build/cmd/coordinator: reject unsupported builder types in slowbot requests #36560

Closed
dmitshur opened this issue Jan 15, 2020 · 2 comments
Closed
Assignees
Milestone

Comments

@dmitshur
Copy link
Member

@dmitshur dmitshur commented Jan 15, 2020

CL 212101 has a comment from Dec 19 2019 that included darwin-amd64-10_8 in a slowbot request. darwin-amd64-10_8 is not a builder type that we support.

https://farmer.golang.org/try?commit=8f9ad60e currently has the darwin-amd64-10_8 build for 8+ hr in waiting_for_machine state:

image

coordinator should probably do something better than attempt to wait for a machine that we know will never become available.

I'm not sure if this is a general feature that needs to be implemented, or if there's something specific regarding darwin builder versions and perhaps this issue affects only darwin-amd64-10_8.

/cc @bradfitz @cagedmantis @toothrot

@bradfitz

This comment has been minimized.

Copy link
Member

@bradfitz bradfitz commented Jan 15, 2020

darwin-amd64-10_8 is not a builder type that we support.

It's listed at https://farmer.golang.org/builders, so technically we do support it. Or at least that's what the code thinks.

Remember we maintain old builder images so we can still test older supported releases of Go. (But 10.8 is so old we can drop support for it: Go 1.12 is our oldest supported release and it requires macOS 10.10+: https://golang.org/doc/go1.12#darwin)

But if macOS 10.8 were still supported, the reason darwin-amd64-10_8 takes forever to spawn is because of the TODO in cmd/makemac (#35698).

In this case, we just need to delete it from the builder config map.

@bradfitz bradfitz added the NeedsFix label Jan 15, 2020
@dmitshur dmitshur self-assigned this Jan 17, 2020
@gopherbot

This comment has been minimized.

Copy link

@gopherbot gopherbot commented Jan 17, 2020

Change https://golang.org/cl/215257 mentions this issue: dashboard: remove darwin-amd64-10_8 builder type

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.