Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net/http: HTTP/2 with MaxConnsPerHost hangs or crashes [1.13 backport] #36583

Closed
gopherbot opened this issue Jan 15, 2020 · 3 comments
Closed

net/http: HTTP/2 with MaxConnsPerHost hangs or crashes [1.13 backport] #36583

gopherbot opened this issue Jan 15, 2020 · 3 comments

Comments

@gopherbot
Copy link

@gopherbot gopherbot commented Jan 15, 2020

@networkimprov requested issue #34941 to be considered for backport to the next 1.13 minor release.

@gopherbot please backport to 1.13

This is a regression, as documented in the issue comments.

@gopherbot
Copy link
Author

@gopherbot gopherbot commented Jan 17, 2020

Change https://golang.org/cl/215177 mentions this issue: [release-branch.go1.13] net/http: only decrement connection count if we removed a connection

@toothrot
Copy link
Contributor

@toothrot toothrot commented Feb 11, 2020

Approved. This is a serious issue with no workaround that only impacts 1.13 and tip.

@gopherbot
Copy link
Author

@gopherbot gopherbot commented Feb 11, 2020

Closed by merging 224a180 to release-branch.go1.13.

@gopherbot gopherbot closed this Feb 11, 2020
gopherbot pushed a commit that referenced this issue Feb 11, 2020
…we removed a connection

The connection count must only be decremented if the persistent
connection was also removed.

Fixes #36583

Change-Id: I5070717d5d9effec78016005fa4910593500c8cf
Reviewed-on: https://go-review.googlesource.com/c/go/+/202087
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-on: https://go-review.googlesource.com/c/go/+/215177
Run-TryBot: Alexander Rakoczy <alex@golang.org>
Reviewed-by: Alexander Rakoczy <alex@golang.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.