Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/gopls: diff metadata before invalidating on changes to go.mod #36589

Open
stamblerre opened this issue Jan 16, 2020 · 0 comments
Open

x/tools/gopls: diff metadata before invalidating on changes to go.mod #36589

stamblerre opened this issue Jan 16, 2020 · 0 comments

Comments

@stamblerre
Copy link
Contributor

@stamblerre stamblerre commented Jan 16, 2020

Right now, gopls invalidates all workspace metadata if there is a change to the user's go.mod file. This is unnecessary if the metadata remains valid after the change. @heschik proposes running go list -m all as a gate during the snapshot cloning to determine if we should invalidate all metadata or keep it in the cache. Either way, we will either invalidate all metadata for the workspace or none.

@gopherbot gopherbot added this to the Unreleased milestone Jan 16, 2020
@stamblerre stamblerre modified the milestones: Unreleased, gopls/v1.0.0 Jan 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.