Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/gopls: removing an import should modify metadata #36607

Closed
stamblerre opened this issue Jan 16, 2020 · 1 comment
Closed

x/tools/gopls: removing an import should modify metadata #36607

stamblerre opened this issue Jan 16, 2020 · 1 comment
Labels
Milestone

Comments

@stamblerre
Copy link
Contributor

@stamblerre stamblerre commented Jan 16, 2020

Right now, we do not reload metadata if a user removes an import, since that technically doesn't require additional data. However, we should still make the relevant modifications in the metadata tree, so that reverse dependencies can be computed correctly and diagnostics can be shown correctly.

@gopherbot gopherbot added this to the Unreleased milestone Jan 16, 2020
@stamblerre stamblerre modified the milestones: Unreleased, gopls/v0.3.0 Jan 16, 2020
@gopherbot gopherbot modified the milestones: gopls/v0.3.0, Unreleased Jan 16, 2020
@stamblerre stamblerre modified the milestones: Unreleased, gopls/v0.3.0 Jan 17, 2020
@stamblerre

This comment has been minimized.

Copy link
Contributor Author

@stamblerre stamblerre commented Jan 22, 2020

Closing this because it's not actually true. go/types will handle raising diagnostic errors when we remove an import.

@stamblerre stamblerre closed this Jan 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.