Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/compile: cannot regenerate rules files using non-tip compiler #36663

Closed
josharian opened this issue Jan 21, 2020 · 4 comments
Closed

cmd/compile: cannot regenerate rules files using non-tip compiler #36663

josharian opened this issue Jan 21, 2020 · 4 comments
Milestone

Comments

@josharian
Copy link
Contributor

@josharian josharian commented Jan 21, 2020

Until recently, it was possible to use a non-tip compiler to regenerate the rules files. This is important, since it (a) prevents you from needing tip to compile to regenerate rules and (b) allows you to use a stable compiler.

That no longer works. Using 1.13 I get:

$ go run *.go
build command-line-arguments: cannot load cmd/internal/obj/riscv: package cmd/internal/obj/riscv is not in GOROOT (/Users/josh/go/1.13/src/cmd/internal/obj/riscv)

Using 1.14 beta 1, I get:

$ go run *.go
RISCV64Ops.go:9:8: use of internal package cmd/internal/obj/riscv not allowed

cc @randall77 @4a6f656c

@toothrot toothrot added this to the Backlog milestone Jan 21, 2020
@4a6f656c
Copy link
Contributor

@4a6f656c 4a6f656c commented Jan 23, 2020

@josharian - I guess we'll just have to duplicate the register names and numbers, like the other platforms do...

@josharian
Copy link
Contributor Author

@josharian josharian commented Jan 23, 2020

@4a6f656c yes. unfortunate, but there you are.

@josharian
Copy link
Contributor Author

@josharian josharian commented Jan 25, 2020

I'd really like this to get fixed soon. It is a serious annoyance when working on rules.

@josharian josharian modified the milestones: Backlog, Go1.14 Jan 25, 2020
@gopherbot
Copy link

@gopherbot gopherbot commented Jan 27, 2020

Change https://golang.org/cl/216518 mentions this issue: cmd/compile/internal/ssa/gen: avoid importing internal riscv64 packages

@gopherbot gopherbot closed this in 8f14f33 Jan 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.